Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Filtering checklist field wasn't supported 2022.4 #1656

Merged
merged 2 commits into from
Jun 16, 2023
Merged

FIX: Filtering checklist field wasn't supported 2022.4 #1656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96b6d47
Added missing checklist filter implementation
JindrichSusen Jun 16, 2023
4a88902
Merge branch '2022.4' into checklist-2022-4
JindrichSusen Jun 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions frontend-html/src/gui/Components/ScreenElements/Table/FilterSettings/FilterSettings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ export const FilterSettings: React.FC<{ autoFocus: boolean, ctx: any }> = observ
})}
/>
);
case "Checklist":
case "TagInput":
return (
<FilterSettingsTagInput
Expand Down
1 change: 1 addition & 0 deletions frontend-html/src/model/entities/FilterConfiguration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,6 +353,7 @@ export class FilterConfiguration implements IFilterConfiguration {
}
break;
}
case "Checklist":
case "TagInput": {
const cellValues = prepareAnyForFilter(this, dataTable.getOriginalCellValue(row, prop));
const filterValues1 = prepareAnyForFilter(this, term.setting.val1);
Expand Down
6 changes: 3 additions & 3 deletions frontend-html/yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1936,9 +1936,9 @@
csstype "^3.0.2"

"@types/react@^17.0.40":
version "17.0.61"
resolved "https://registry.yarnpkg.com/@types/react/-/react-17.0.61.tgz#e9c790bd9000bb6c16c293ea70daebc36bb15b1d"
integrity sha512-bAb4j3LH2FLMCmZWow7XIKTt51+duiDjjfzR6gjhqT3ZJn9A20G9BuXELkhmM6dI6ahNpDqyL4eUAJVmR0b4JA==
version "17.0.62"
resolved "https://registry.yarnpkg.com/@types/react/-/react-17.0.62.tgz#2efe8ddf8533500ec44b1334dd1a97caa2f860e3"
integrity sha512-eANCyz9DG8p/Vdhr0ZKST8JV12PhH2ACCDYlFw6DIO+D+ca+uP4jtEDEpVqXZrh/uZdXQGwk7whJa3ah5DtyLw==
dependencies:
"@types/prop-types" "*"
"@types/scheduler" "*"
Expand Down