Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Busy indicator was not active right after row states were requested #1779

Closed
wants to merge 3 commits into from

Conversation

JindrichSusen
Copy link
Contributor

No description provided.

so it was not clear that the displayed data was not in final state during scrolling
@JindrichSusen JindrichSusen changed the title Busy indicator when scrolling FIX: Busy indicator was not active right after row states were requested Aug 2, 2023
@origambot
Copy link

This pull request has been mentioned on ORIGAM Community. There might be relevant details there:

https://community.origam.com/t/when-scrolling-its-not-communicated-to-a-user-the-data-are-not-complete/2941/4

now it only triggers the busy indicator
@JindrichSusen JindrichSusen marked this pull request as draft August 8, 2023 14:06
@@ -28,6 +28,7 @@ import { handleError } from "model/actions/handleError";
import { flashColor2htmlColor } from "@origam/utils";

const maxRowStatesInOneCall = 100;
const loadingDelay = 666;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the right value?

@JindrichSusen
Copy link
Contributor Author

The issue was solved in a different way

@washibana washibana deleted the busy-indicator-when-scrolling branch January 2, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants