Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Redundant master record calls avoided #1836

Merged
merged 4 commits into from Aug 31, 2023
Merged

FIX: Redundant master record calls avoided #1836

merged 4 commits into from Aug 31, 2023

Conversation

JindrichSusen
Copy link
Contributor

No description provided.

@JindrichSusen
Row changed reaction was not disposed
2409f22 
and new reactions were started after changing filters
@JindrichSusen
MasterRecord was called twice after changing filters
10c9d7b
@JindrichSusen
disposers removed
2f69b15 
because they did not contain up to date SelectedRowReaction disposer and were never used anyway
@origambot
Copy link

This pull request has been mentioned on ORIGAM Community. There might be relevant details there:

https://community.origam.com/t/filtering-by-an-enumeration-value-causes-calling-masterrecord-multiple-times-on-slow-data-connections/2934/3

@tvavrda tvavrda merged commit f12b470 into master Aug 31, 2023
10 checks passed
@tvavrda tvavrda deleted the redundant-master-record-calls branch August 31, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvavrda tvavrda tvavrda approved these changes

@washibana washibana Awaiting requested review from washibana washibana is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JindrichSusen @origambot @tvavrda