Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE: Optimize datastructure rule evaluation #1918

Merged
merged 1 commit into from Sep 15, 2023
Merged

FEATURE: Optimize datastructure rule evaluation #1918

merged 1 commit into from Sep 15, 2023

Conversation

urbanekv
Copy link
Contributor

  • call rowstates in the final UpdateObject() method, not from UpdateObject() coming from doing dependency field reseting
  • compute and remember a row-level-security result for a security type (read, write, etc) and column which doesn’t have any rule and apply it for all the further columns without any field-level-row-level security rule
  • compute and cache a row-level-security rule result for a current row and use cached value whenever it’s needed again

@urbanekv @washibana
FEATURE: Optimize datastructure rule evaluation (#1912)
98dfcdf 
* call rowstates in the final UpdateObject() method, not from UpdateObject() coming from doing dependency field reseting
* compute and remember a row-level-security result for a security type (read, write, etc) and column which doesn’t have any rule and apply it for all the further columns without any field-level-row-level security rule
* compute and cache a row-level-security rule result for a current row and use cached value whenever it’s needed again

---------

Co-authored-by: Václav Urbánek <vaclav.urbanek@advantages.cz>
Co-authored-by: Petr Hrehorovsky <washi@volny.cz>
@origambot
Copy link

This pull request has been mentioned on ORIGAM Community. There might be relevant details there:

https://community.origam.com/t/optimize-datastructure-rule-evaluation/2998/6

@washibana washibana changed the title FEATURE: Optimize datastructure rule evaluation (#1912) FEATURE: Optimize datastructure rule evaluation Sep 15, 2023
@washibana washibana merged commit 6eaa94c into 2023.1 Sep 15, 2023
9 checks passed
@washibana washibana deleted the optimize-data-structure-rules-evaluation-2023-1 branch September 15, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@washibana washibana washibana approved these changes

@tvavrda tvavrda Awaiting requested review from tvavrda tvavrda is a code owner

@JindrichSusen JindrichSusen Awaiting requested review from JindrichSusen JindrichSusen is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@urbanekv @origambot @washibana