Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Filter does not update children #1933

Merged
merged 2 commits into from Sep 20, 2023
Merged

FIX: Filter does not update children #1933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a20494
Child records were not updated after applying a filer
JindrichSusen Sep 19, 2023
0d92330
Readme updated
JindrichSusen Sep 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 10 additions & 0 deletions frontend-html/README.md
View file
Open in desktop
Expand Up @@ -62,4 +62,14 @@ Try running it with the browser path specified:

```BROWSER=/usr/bin/firefox yarn start```

#### Debug Constants
You can set these constants in the browser's local storage:

`debugNoPolling` will prevent work queue refresh from running

`debugNoPolling_notificationBox` will prevent notifications refresh from running

`debugNoPolling_chatrooms` will prevent chat refresh from running



9 changes: 2 additions & 7 deletions frontend-html/src/model/entities/FormScreenLifecycle/FormScreenLifecycle.tsx
View file
Open in desktop
Expand Up @@ -724,7 +724,6 @@ export class FormScreenLifecycle02 implements IFormScreenLifecycle02 {
yield*this.readFirstChunkOfRows({
rootDataView: rootDataView,
preloadIsDirty: preloadIsDirty,
runChangeRowReaction: true
});
}
}
Expand Down Expand Up @@ -879,7 +878,6 @@ export class FormScreenLifecycle02 implements IFormScreenLifecycle02 {

*readFirstChunkOfRows(args: {
rootDataView: IDataView,
runChangeRowReaction: boolean
preloadIsDirty?: boolean
}): any {
const rootDataView = args.rootDataView;
Expand Down Expand Up @@ -922,9 +920,7 @@ export class FormScreenLifecycle02 implements IFormScreenLifecycle02 {
}
rootDataView.restoreViewState();
} finally {
if(args.runChangeRowReaction){
rootDataView.lifecycle.startSelectedRowReaction(!args.preloadIsDirty);
}
rootDataView.lifecycle.startSelectedRowReaction(!args.preloadIsDirty);
this.monitor.inFlow--;
}
}
Expand Down Expand Up @@ -968,8 +964,7 @@ export class FormScreenLifecycle02 implements IFormScreenLifecycle02 {
do {
this._readFirstChunkOfRowsScheduled = false;
yield*this.readFirstChunkOfRows({
rootDataView: rootDataView,
runChangeRowReaction: false
rootDataView: rootDataView
});
} while (this._readFirstChunkOfRowsScheduled);
} finally {
Expand Down