FIX: Contains filter on lookup column returned too many values 2023.1 #2058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because the SQL behind it applied the filter on the ids instead of the lookup values. The time rendered in the SQL was also wrong, not respecting culture and formatting of the values from UIService/GetLookupLabelsEx (that is what is displayed in the grid).
|
PgSQL implementation of the Format method is not implemented yet. |
because in is not implemented and implementing it is not a priority now
|
This pull request has been mentioned on ORIGAM Community. There might be relevant details there: https://community.origam.com/t/contains-filer-does-not-work-on-lookup-filed/3097/3 |
washibana
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because the SQL behind it applied the filter on the ids instead of the lookup values. The time rendered in the SQL was also wrong, not respecting culture and formatting of the values from UIService/GetLookupLabelsEx (that is what is displayed in the grid).