Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Adding a new item to combobox failed if the underlying field required… #2202

Merged
merged 2 commits into from Nov 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Expand Up @@ -49,8 +49,8 @@ public class NewRecordScreenBinding : AbstractSchemaItem, IAuthorizationContextC
public NewRecordScreenBinding(Guid schemaExtensionId) : base(schemaExtensionId) { }

public NewRecordScreenBinding(Key primaryKey) : base(primaryKey) {}


[Browsable(false)]
public bool IsAvailable
{
get
Expand Down
1 change: 1 addition & 0 deletions backend/Origam.Schema/AbstractSchemaItem.cs
Expand Up @@ -642,6 +642,7 @@ private AbstractSchemaItem GetRootItem(AbstractSchemaItem parentItem)
return GetRootItem(parentItem.ParentItem);
}

[Browsable(false)]
public IEnumerable<AbstractSchemaItem> Parents
{
get
Expand Down
Expand Up @@ -67,6 +67,7 @@ public override void Init()
row, true, SecurityManager.CurrentUserProfile().Id);
row.Table.NewRow();

RemoveNullConstraints(dataSet);
dataSet.Tables[rootEntity.Name].Rows.Add(row);
SetDataSource(dataSet);
}
Expand Down
2 changes: 1 addition & 1 deletion backend/Origam.Server/Session Stores/SessionStore.cs
Expand Up @@ -768,7 +768,7 @@ public virtual void OnDispose()
#endregion

#region Private Methods
private static void RemoveNullConstraints(DataSet dataset)
protected static void RemoveNullConstraints(DataSet dataset)
{
foreach (DataTable table in dataset.Tables)
{
Expand Down