Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Possible to invoke ExecuteAction while UpdateObject was running #2247

Merged
merged 1 commit into from
Nov 24, 2023
Merged

FIX: Possible to invoke ExecuteAction while UpdateObject was running #2247

merged 1 commit into from
Nov 24, 2023

Conversation

urbanekv
Copy link
Contributor

  • Added forgotten locks to session store. It used to happen to execute an action when long running UpdateObject was still processing. Without lock protection it led to unpredictable results.
  • Secured all SessionStore.ExecueAction with lock and "already running" protection.
  • Removed unused CachedFormIds, backward compatible API change.

@urbanekv
FIX: Possible to invoke ExecuteAction while UpdateObject was running (#…
a9f8ed1 
…2231)

* Added forgotten locks to session store. It used to happen to execute an action when long running UpdateObject was still processing. Without lock protection it led to unpredictable results.
* Secured all SessionStore.ExecueAction with lock and "already running" protection.
* Removed unused CachedFormIds, backward compatible API change.

---------

Co-authored-by: Václav Urbánek <vaclav.urbanek@advantages.cz>
@origambot
Copy link

This pull request has been mentioned on ORIGAM Community. There might be relevant details there:

https://community.origam.com/t/next-in-workflow-had-caused-unpredictable-behavior-when-updateobject-had-been-still-running/3190/3

@washibana washibana merged commit ce52fcd into master Nov 24, 2023
9 checks passed
@washibana washibana deleted the possible-to-invoke-executeaction-while-updateobject-was-running--master branch November 24, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@washibana washibana washibana approved these changes

@tvavrda tvavrda Awaiting requested review from tvavrda tvavrda is a code owner

@JindrichSusen JindrichSusen Awaiting requested review from JindrichSusen JindrichSusen is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@urbanekv @origambot @washibana