Added ability to redirect user from subdomain to some predefined url. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| array('subdomain.example.com'), | ||
| array('multi.subdomain.example.com'), | ||
| array('v.e.r.y.m.u.l.t.i.s.u.b.d.o.m.a.i.n.example.com'), | ||
| array('subdomain.example-is.com'), |
There was a problem hiding this comment.
Tests fail if I add 'localhost' to this list.
There was a problem hiding this comment.
And I think example.co.uk won't work also. I have to rethink a bit. It's not that easy to know if domain contains subdomain. One possible solution would be, that you would need to specify used domain in config. Than it's quite easy. What you think?
There was a problem hiding this comment.
Yes I was thinking something similar as well. I think it'd be best to have a list of patterns to match against the host and then only redirect matching hosts.
There was a problem hiding this comment.
Maybe for starters we could just use this parameter router.request_context.host to know which is the main domain.
matejvelikonja
added a commit
that referenced
this pull request
Apr 18, 2014
Added ability to redirect user from subdomain to some predefined url.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.