Limit pagination include to index. Fix pagination calc #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was trying to allow the pagination block to be overridden but it's a bit tricky as the inheritance is the wrong way around. |
|
@pkraeutli could you please have a look at this pull request. Thanks |
| @@ -81,6 +81,11 @@ | |||
| {% endfor %} | |||
| </tbody> | |||
| </table> | |||
|
|
|||
| {% block armb_pagination %} | |||
There was a problem hiding this comment.
Just to allow it to be overridden, not particularly useful any more though. We have tried to keep changes backward compatible
pkraeutli
added a commit
that referenced
this pull request
Mar 14, 2016
Limit pagination include to index. Fix pagination calc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made a mistake about the pagination sorry. Must have been having a blonde moment