fix: added catch when loading js with import(...) (#328)

Co-authored-by: Bartłomiej Piura <bartlomiej.piura@softiq.pl>
originjs · Jan 28, 2023 · 97ed8f7 · 97ed8f7
1 parent 870e9d3
commit 97ed8f7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/lib/src/dev/remote-development.ts b/packages/lib/src/dev/remote-development.ts
@@ -95,7 +95,7 @@ async function __federation_method_ensure(remoteId) {
       });
     } else if (importTypes.includes(remote.format)) {
       // loading js with import(...)
-      return new Promise(resolve => {
+      return new Promise((resolve, reject) => {
         const getUrl = typeof remote.url === 'function' ? remote.url : () => Promise.resolve(remote.url);
         getUrl().then(url => {
           import(/* @vite-ignore */ url).then(lib => {
@@ -107,7 +107,7 @@ async function __federation_method_ensure(remoteId) {
               remote.inited = true;
             }
             resolve(remote.lib);
-          })
+          }).catch(reject)
         })
       })
     }

diff --git a/packages/lib/src/prod/remote-production.ts b/packages/lib/src/prod/remote-production.ts
@@ -100,7 +100,7 @@ async function __federation_method_ensure(remoteId) {
       });
     } else if (importTypes.includes(remote.format)) {
       // loading js with import(...)
-      return new Promise(resolve => {
+      return new Promise((resolve, reject) => {
         const getUrl = typeof remote.url === 'function' ? remote.url : () => Promise.resolve(remote.url);
         getUrl().then(url => {
           import(/* @vite-ignore */ url).then(lib => {
@@ -112,7 +112,7 @@ async function __federation_method_ensure(remoteId) {
               remote.inited = true;
             }
             resolve(remote.lib);
-          })
+          }).catch(reject)
         })
       })
     }