Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

Do correct swapping of web3 in global context #29

Closed
wanderingstan opened this issue Jan 7, 2018 · 4 comments
Closed

Do correct swapping of web3 in global context #29

wanderingstan opened this issue Jan 7, 2018 · 4 comments
Labels
javascript
Projects
Origin Project Sprints

Comments

@wanderingstan
Copy link
Collaborator

react-web3 package is slick, but doesn't do the reccomended swapping in of local version of web3, as described here:
https://github.com/MetaMask/faq/blob/master/DEVELOPERS.md#partly_sunny-web3---ethereum-browser-environment-check

We're already using my patched version of react-web3. I'm in contact with the developer of it, though he is slow to respond.
wanderingstan added a commit that referenced this issue Jan 7, 2018
@wanderingstan
Removed unused web3-service.
5ad51fe 
We now get web3 via the react-web3 component. Note that we still need to update it do correct web3 swapping: #29
@wanderingstan wanderingstan mentioned this issue Jan 31, 2018
Closed
@matthewliu matthewliu added this to Not prioritized in Origin Project Sprints via automation Apr 14, 2018
@wanderingstan
Copy link
Collaborator Author

@micahalcorn Did you fix this in when you exorcized react-web3?
Or maybe @tyleryasaka , in your update to how we do web3 in platform?

@micahalcorn
Copy link
Member

@wanderingstan no, I believe that @aiham was working on this.

@micahalcorn
Copy link
Member

I believe this will happen as a byproduct of @nick's identity integration this week.

@micahalcorn
Copy link
Member

Done via 546e2d2 ✅

Origin Project Sprints automation moved this from Backlog to 🕵️Done 5/2/18-5/15/18 May 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
javascript
Projects
Origin Project Sprints
  
🕵️Done 5/2/18-5/15/18
Milestone
No milestone
Development

No branches or pull requests
2 participants
@micahalcorn @wanderingstan