Option to disable automatic payouts via config file

[lukeskinner]

Would you accept a PR that allows me to turn off the automatic ETH transaction payouts in the node?

The PR (at a glance) will probably be changing the /modules/command/dh/dh-pay-out-command.js file to check the config for a new setting in the execute function.

The reason for this being I'm currently paying outs offers for my nodes via the OT Hub website. Doing it this way I can do the payout via the management wallet and at a low gas price - this then has no effect on the node and it's operational wallet.

Example of the cost savings from lowering gas price by doing payouts externally:
The default 20 Gwei gas price on the operational wallet costs 0.00316291 ETH ($0.49) per payout on average.
Doing the payout at 2 Gwei gas price on the management wallet costs 0.00032378 ETH ($0.05) per payout on average.

As a side note OT Hub also checks all the conditions within the holding smart contract so it will block the payout transaction from being sent if it will fail anyway in the smart contract.

[kipliklotrika]

Hi @lukeskinner,

Everything you said makes sense and something like you proposed could be implemented. The actual change should be in modules/command/dh/dh-offer-finalized-command.js where payout command is issued. We'll get into it soon so no need for PR now.

[lukeskinner]

Thanks for adding this feature! I'll enable it on my nodes later today.