Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print - incorrect style for highlighted/selected objects after print #1482

Closed
asemoller opened this issue Mar 2, 2022 · 4 comments · Fixed by #1514
Closed

Print - incorrect style for highlighted/selected objects after print #1482

asemoller opened this issue Mar 2, 2022 · 4 comments · Fixed by #1514

Comments

@asemoller
Copy link
Contributor

Describe the bug
When you return to the map after printing, the style of the selected item is incorrect.

To Reproduce
Steps to reproduce the behavior:

  1. Go to print
  2. Close print
  3. Select an object
  4. See error

Expected behavior
The selected object should have the style (or default style) from the json file.

Screenshots

print-selected-style-issue

Additional context
Related to #1476?

@jokd jokd added the bug label Mar 2, 2022
@jokd
Copy link
Contributor

jokd commented Mar 2, 2022

Seems related, @Grammostola

@sonjahalmstad
Copy link

We get the same problem!
Printproblem_

@Grammostola
Copy link
Contributor

Grammostola commented Mar 2, 2022

Acknowledged. It seems the selection goes missing on print preview entry and accomodating this issue relates to the fix I was working on for the other one (which deals with print preview exit).

suppressNewDPIMethod does help by undoing much of the recent resolutions change, which is just as well because it was intended for things like this . So to summarize: use the

"suppressNewDPIMethod": true 

option for the print control if this issue is a showstopper, until I or someone else gets a handle on it : )

I think the problem is creating a new style based on the original and applying it to all features, rather than changing the scale of all features' styles and am working on it.

@Grammostola
Copy link
Contributor

It seems to not be an issue with theme (wfs) layers; they are treated differently. "Changing the scale of all features' styles" isn't a functional idea because a feature won't respond to getStyle() if inherited from its layer rather than being subjected to setStyle(). Unless someone acts quicker or sees an issue with the idea I will look into whether treating wfs layers with non-theme styles like those with theme styles are now is an alternative.

@Grammostola Grammostola added this to Eskilstuna in Origo member roadmap Mar 23, 2022
sweco-sedalh pushed a commit to sweco-sedalh/origo that referenced this issue Apr 6, 2022
sweco-sedalh pushed a commit to sweco-sedalh/origo that referenced this issue Apr 26, 2022
sweco-sedalh pushed a commit to sweco-sedalh/origo that referenced this issue May 27, 2022
johnnyblasta added a commit that referenced this issue May 30, 2022
Fix for #1476 and #1482 (correct styling upon exiting print view)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

4 participants