-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: set maxheight for layer search #1886
Conversation
I haven't tested this one but how are searches handled if the legend only contains a collapsed group with many layers like in issue #1641? |
It will look half decent. The max-height is set as if the legend was full height so it will overflow the legend when it is smaller so I was lying a bit in my previous comment: Dunno if there's a better way of doing it. |
Maybe its enough to set max height to 50% of the legend max height, at least this scenario will look better |
However, this still applies: |
Right on, now its fixed and the height is set to approx half the max height of the legend. Fixed scrolling for the search control as well |
Yes, the legend search works well! |
Fixes #1827
Set max height element containing search result so it won't overflow the legend container and make it scrollable. Also set the width to match the legend.