-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds and updates SearchList #604
Conversation
Replace the attributes of for example editor point with:
|
@tonnyandersson Tnx I will look into that. |
Looks better. But I'm not sure how this is supposed to work. For example, is this an expected behaviour? The filter function seems to return all objects on the list, even if the input string is not in "src" or "value". This is what happens when setting "minChars" to 0 or 1. Setting "minChars" to 2 works better but decreases sensitivity, obviously. |
@tonnyandersson Yes it's expected behavior, the user should be prompted with available options. If you would rather not get a list of all possible items, then you should not use this option, its not mandatory. If Min-/ Max- chars params does not satisfy you needs, feel free to submit an ISSUE/PR. |
When entering a letter or string into the search box, I expect the list to show all items containing that letter/string. If none of the items contain the specific letter/string, I would expect the list to be empty. For example, now if I enter the letter "w" into the search box, the list shows all available options, which is not what I had expected. However, if I go on and enter "ww", the list shows up empty, which is totally in line with my expectations. Makes no sense to me. |
* Update package.json (#1) Fixes origo-map#576 * possibility of having sldStyle in index.json style section * empty string for style instead of undefined * changing variable names from sldStyle to wmsStyle
* Update package.json (#1) Fixes origo-map#576 * adding support for extendedLegend * a more informative comment * removing unused variable
* Fixes origo-map#402 * update after PR origo-map#603 comments * updates css to use global colors PR#603
* add 0 margin top @ flex column * Ignore first commit
* Update package.json (#1) Fixes origo-map#576 * styleSettings caused the whole application to crash if no style is provided in the index.json
@daRasmussen I agree with @tonnyandersson regarding the expected behaviour when you type a letter thats not part of any option, the list should be empty. Not showing everything. |
@jokd will do |
Still has that weird filtering behaviour mentioned previously. |
Closing this due to merge conflicts, see updated PR #1005 |
Fixes #463