Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add token validation in qwik server #698

Closed
wants to merge 2 commits into from

Conversation

ymoukhli
Copy link
Contributor

@ymoukhli ymoukhli commented Feb 2, 2024

add a token validation before loading the page.

expected behavior:

if a user change the role to admin in the jwt and try to go to dashboard page it will log him out.

issue:

#687

Copy link

vercel bot commented Feb 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
reduced-to ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2024 3:59pm

@ymoukhli ymoukhli changed the title add token validation in quick server add token validation in qwik server Feb 2, 2024
@origranot
Copy link
Owner

Hey @ymoukhli,

Quick heads up on the PR – with our server-side validation in NestJS already in place, I'm questioning if the client-side token validation is doing us any real favors. Especially thinking about multi-user, this approach might not hold up too well.

Considering we're pretty covered by the backend security, focusing our efforts there or on enhancing other security aspects might be more beneficial. This PR, as is, might not be the solution we're looking for. We might need to consider closing this issue and brainstorming a bit more on what really needs our attention.

What's your take on this?

@ymoukhli
Copy link
Contributor Author

ymoukhli commented Feb 4, 2024

Hello @origranot

I concur that this Pull Request won't contribute significantly; it merely addresses the open issue. If I come across any vulnerabilities, Il make sure to let you know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants