Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly set ValueType to Counter or Gauge #8

Merged
merged 1 commit into from
May 11, 2020
Merged

Correctly set ValueType to Counter or Gauge #8

merged 1 commit into from
May 11, 2020

Conversation

james-bebbington
Copy link
Contributor

@james-bebbington james-bebbington commented May 11, 2020 •
edited

Fixes #7

@james-bebbington james-bebbington mentioned this pull request May 11, 2020
Merged
odeke-em
odeke-em approved these changes May 11, 2020
View reviewed changes
Copy link
Member

@odeke-em odeke-em left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this change @james-bebbington and great catching you here, formally.

I have to jog my memory on why I didn’t use the derived type as it has been almost 2 years since I wrote that code, but the use of derived type LGTM!

@odeke-em odeke-em merged commit 7197eac into orijtech:master May 11, 2020
@james-bebbington
Copy link
Contributor Author

james-bebbington commented May 11, 2020 •
edited

Thank you for this change @james-bebbington and great catching you here, formally.

I have to jog my memory on why I didn’t use the derived type as it has been almost 2 years since I wrote that code, but the use of derived type LGTM!

No worries, @bogdandrutu was actually the one that noticed it. Thanks for the quick merge! Could you please tag this for release as well so we can update Open Telemetry Collector to use the latest version?

@odeke-em
Copy link
Member

Awesome, thank you both @james-bebbington and @bogdandrutu. I've cut the release v0.0.5, done https://github.com/orijtech/prometheus-go-metrics-exporter/releases/tag/v0.0.5.

@james-bebbington
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odeke-em odeke-em odeke-em approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exporter does not correctly set Counter or Gauge ValueType
2 participants
@james-bebbington @odeke-em