Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing tests for endianness functions used in SHA2 #162

Closed
brycx opened this issue Dec 22, 2020 · 1 comment
Closed

Add missing tests for endianness functions used in SHA2 #162

brycx opened this issue Dec 22, 2020 · 1 comment
Assignees
@brycx
Labels
testing All testing, except for fuzzing related
Milestone
v0.16

Comments

@brycx
Copy link
Member

brycx commented Dec 22, 2020 •
edited
Loading

The endianness-conversion functions added in #161 are missing tests. Should be merged into v016.

Awaiting merge of #161.
@brycx brycx added the testing All testing, except for fuzzing related label Dec 22, 2020
@brycx brycx added this to the v0.16 milestone Dec 22, 2020
@brycx brycx added the good first issue Good for newcomers label Dec 22, 2020
@brycx brycx self-assigned this Mar 9, 2021
@brycx brycx removed the good first issue Good for newcomers label Mar 9, 2021
brycx added a commit that referenced this issue Mar 9, 2021
@brycx
test: Add missing tests for endianness functions. Closing #162
3193153
brycx added a commit that referenced this issue Mar 12, 2021
@brycx
Cleanup of SHA2 implementations (#181)
c15c0e8 
* sha2: Generalized Sha2 core using Word newtype

* Cleanup min_const_generics implementations

* sha2: Test with quickcheck macros can be enabled

* endianness: Remove now unused u64 BE releated funcs

* sha2: Snake case sha2Core -> sha2_core

* sha2: Snake case W32/W64 -> w32/w64

* sha2: NIT

* hmac: allow(dead_code) - clippy complains that associated const is not used, when it actually is (HKDF and PBKDF2)

* sha2: Use .map() for checked_add and checked_shl impl

* hmac: Return Result from _new if not taking a SecretKey newtype, which is the only time unwrapping is OK because then the key has been pre-padded

* ci: Temporarily disable deny-warnings on lints

* ci: Temporarily disable deny-warnings on lints

* sha2: Add u64 BE conversion test

* test: Add missing tests for endianness functions. Closing #162

* sha2: Feature-gate less_than_or_equal to debug_assertions and test

* sha2: std-gate quickcheck tests

* sha2: Minor doc corrections

* sha2: Minor doc corrections - match old documentation

* hmac: Minor doc corrections

* pbkdf2: Minor doc corrections

* hkdf: Revert changes to original function sigantures
@brycx
Copy link
Member Author

brycx commented Mar 12, 2021

Fixed in #181.

@brycx brycx closed this as completed Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brycx brycx

Labels
testing All testing, except for fuzzing related
Projects
None yet
Milestone
v0.16
Development

No branches or pull requests
1 participant
@brycx