Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert test vector files to pure-Rust testing modules [Python/Rust] #38

Closed
brycx opened this issue Nov 22, 2018 · 2 comments
Closed

Convert test vector files to pure-Rust testing modules [Python/Rust] #38

brycx opened this issue Nov 22, 2018 · 2 comments
Assignees
Labels
testing All testing, except for fuzzing related

Comments

@brycx
Copy link
Member

brycx commented Nov 22, 2018

The below test modules rely on ring's testing framework to read the test vectors from files in test_data:

  • other_poly1305.rs
  • boringssl_chacha20_poly1305.rs
  • boringssl_xchacha20_poly1305.rs

These should be converted into pure-Rust testing modules, like it has been done with the NIST CAVP HMAC test vectors. Python conversion scripts used to convert such test vector files can be found in test_generation for reference. Conversion scripts for any of the above modules are also preferred to be in Python or Rust.

@brycx brycx added the good first issue Good for newcomers label Nov 22, 2018
@brycx
Copy link
Member Author

brycx commented Nov 22, 2018

Using ring's testing framework seems to also block testing in CI with target mips64-unknown-linux-gnuabi64.

That target has now been set to allow failure, but should be re-tested without failure, once the ring dev-dependency is gone.

brycx added a commit that referenced this issue Nov 22, 2018
@brycx brycx removed the good first issue Good for newcomers label Nov 28, 2018
@brycx brycx self-assigned this Nov 28, 2018
brycx added a commit that referenced this issue Nov 28, 2018
@brycx
Copy link
Member Author

brycx commented Nov 28, 2018

Fixed in 47ba12d.

@brycx brycx closed this as completed Nov 28, 2018
@brycx brycx added the testing All testing, except for fuzzing related label Dec 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing All testing, except for fuzzing related
Projects
None yet
Development

No branches or pull requests

1 participant