Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This packages imply way too much #381

Closed
wants to merge 2 commits into from
Closed

Conversation

mitar
Copy link

@mitar mitar commented Dec 31, 2015

I would like to complain a bit. The approach in this repository where so many packages are implyed, makes it really hard to reuse this system with other Meteor packages:

It destroys the whole purpose of dependencies by creating one monolithic package you can or cannot use.

For example, it is now impossible to use orionjs:core together with Blaze Components because orionjs:core implies orionjs:base which implies blaze-html-templates. Why it has to imply it and not just depend on it? This makes it problematic for users who would like to swap templating with Blaze Components and get also server side rendering.

@mitar
Copy link
Author

mitar commented Dec 31, 2015

Or probably better solution would be that orion:core would not imply orion:base, just depend on it.

@mitar
Copy link
Author

mitar commented Dec 31, 2015

This is now a better fix.

@macrozone
Copy link

Has this version been published to atmosphere? I ran in the exaclty described problem with BlazeComponents.

Edit: sorry, did not realized, that this PR is not merged yet.

@nicolaslopezj
Copy link
Member

This will be fixed in 1.8

nicolaslopezj added a commit that referenced this pull request Mar 9, 2016
@macrozone
Copy link

👍 awesome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants