Add supernova mode to AI vs AI on demo #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| category | ||
| displacement | ||
| movement-type | ||
| movement-cost]) |
There was a problem hiding this comment.
I would've loved to understand why using long for the type hint is better from your commit message :p
There was a problem hiding this comment.
My bad!
A long is a primitive, and with such, the jvm can do primitive very fast math. With the Integer reference type, it has to box/unbox it. If it has no type hint, clojure will use heavy reflection to find out the type.
More details about performance issues: https://www.youtube.com/watch?v=iQwQXVM6oiY
There was a problem hiding this comment.
Also updated the commit message.
|
@donbonifacio just finished |
Replace Integer for primitive long and add more type hints to the unit. A long is a primitive, and with such, the jvm can do primitive very fast math. With the Integer reference type, it has to box/unbox it. If it has no type hint, clojure will use heavy reflection to find out the type. More details about performance issues: https://www.youtube.com/watch?v=iQwQXVM6oiY
Demo was still using the old game-mode/process. Changed to game-progress/next-stage. We now have a working demo.
Minor change: moved the intro panel with text to the top, and now the serialized game can be right next to the game. This looks more like a playground/test zone and will be useful to test the AI.
On the demo page AI vs AI, added a button that restarts the game and sets the mode to supernova.
Had to rewrite the image to the olf flag unit and have the current mode always on the state. Created an issue to solve this later: #36
I was storing on the webapp state the mode for the ai vs ai game. Whenever a game started, I'd use that mode to start a new game. Changed that logic to store an actual map with the full game options. By default it uses `game-progress/default-new-game-options`. For the supernova mode, it just associates the :supernova mode to the defaults.
|
@quimrstorres ready for a re-review. |
|
@donbonifacio everything looks great! Awesome job! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#34