Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional Serde support #1

Closed
dtolnay opened this issue Dec 29, 2017 · 8 comments
Closed

Add optional Serde support #1

dtolnay opened this issue Dec 29, 2017 · 8 comments

Comments

@dtolnay
Copy link

dtolnay commented Dec 29, 2017

In #rust today someone was struggling to serialize rpds::Vector (logs). It would be great to have Serde impls for these data structures that can be enabled by a serde cfg.

@orium
Copy link
Owner

orium commented Dec 30, 2017

In the next few days I will probably not be able to get any coding done, but once I'm I will work on it. (Meanwhile if someone wants to work on a PR I might be able to review/merge it.)

@idupree
Copy link
Contributor

idupree commented Jan 5, 2018

I started implementing this in https://github.com/idupree/rpds/commits/serde-impls -- does it look reasonable so far?

@dtolnay
Copy link
Author

dtolnay commented Jan 5, 2018

Looks good so far!

@orium
Copy link
Owner

orium commented Jan 5, 2018

Yup, looks good. I only have some cosmetic/organization suggestions but I will leave that to the PR.

@idupree
Copy link
Contributor

idupree commented Jan 5, 2018

Might I have your cosmetic suggestions now so that I don't have to redo cosmetic changes for every data structure?

@idupree
Copy link
Contributor

idupree commented Jan 5, 2018

(I could send it in a provisional pull request if it's easier to comment on that way)

@idupree
Copy link
Contributor

idupree commented Jan 5, 2018

Implemented all of them (Vector, List, Queue, Stack, RedBlackTreeSet, HashTrieSet, RedBlackTrieMap, HashTrieMap). Note in case you had pulled the initial commit series: I've git-rebased since then. Pull request: #2

@orium
Copy link
Owner

orium commented Jan 9, 2018

Closed by #4

@orium orium closed this as completed Jan 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants