-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional Serde support #1
Comments
In the next few days I will probably not be able to get any coding done, but once I'm I will work on it. (Meanwhile if someone wants to work on a PR I might be able to review/merge it.) |
I started implementing this in https://github.com/idupree/rpds/commits/serde-impls -- does it look reasonable so far? |
Looks good so far! |
Yup, looks good. I only have some cosmetic/organization suggestions but I will leave that to the PR. |
Might I have your cosmetic suggestions now so that I don't have to redo cosmetic changes for every data structure? |
(I could send it in a provisional pull request if it's easier to comment on that way) |
Implemented all of them (Vector, List, Queue, Stack, RedBlackTreeSet, HashTrieSet, RedBlackTrieMap, HashTrieMap). Note in case you had pulled the initial commit series: I've git-rebased since then. Pull request: #2 |
Closed by #4 |
In #rust today someone was struggling to serialize rpds::Vector (logs). It would be great to have Serde impls for these data structures that can be enabled by a
serde
cfg.The text was updated successfully, but these errors were encountered: