Small improvement for integer ranges #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orklah
reviewed
Mar 20, 2024
composer.json
Outdated
| @@ -25,8 +25,8 @@ | |||
| } | |||
| }, | |||
| "require-dev": { | |||
| "vimeo/psalm": "^4.0|^5", | |||
| "nikic/php-parser": "^4.0" | |||
| "vimeo/psalm": "dev-master", | |||
There was a problem hiding this comment.
I don't think this change is on purpose?
There was a problem hiding this comment.
Well, it does not affect dependencies anyway, I made it to test that everything is scanned fine
There was a problem hiding this comment.
I may have made a mistake somewhere when creating this, but I'd expect some constraint to prevent a user from requiring this plugin with a Psalm in version 3 or in version 7 for example.
if require-dev is not checked, then maybe that constraint should be put in require?
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
& misc modernization.
Could you please tag after merging?