Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsound usages of unsafe implementation Vec<u32> from to u8 #22

Open
llooFlashooll opened this issue May 26, 2024 · 0 comments
Open

Unsound usages of unsafe implementation Vec<u32> from to u8 #22

llooFlashooll opened this issue May 26, 2024 · 0 comments

Comments

@llooFlashooll
Copy link

Hi, I am scanning the base-x in the latest version with my own static analyzer tool.

Unsafe conversion found at: src/bigint.rs:115:30: 115:65.

let mut bytes = Vec::with_capacity(len);
unsafe {
    bytes.set_len(len);

    let chunks_ptr = (self.chunks.as_ptr() as *const u8).offset(skip as isize);

    ptr::copy_nonoverlapping(chunks_ptr, bytes.as_mut_ptr(), len);

}

This unsound implementation would create a misalignment issues from different integers.

The problematic value is further manipulated at: src/bigint.rs:115:30: 115:87

This would potentially cause undefined behaviors in Rust. If we further manipulate the problematic converted types, it would potentially lead to different consequences. I am reporting this issue for your attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant