Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup teardown #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Cleanup teardown #1

wants to merge 3 commits into from

Conversation

backkem
Copy link

@backkem backkem commented Dec 20, 2019

Main problem is that this is racy:

	select {
	case bu.stopCh <- struct{}{}:
	default:
	}

You see this from time-to-time. However, you can actually end up in the default case incorrectly if the timer routine is busy and not actively receiving on the stopCh channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant