Fix #9: Handle TXT Records correctly #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the current version, of SwiftNIO it throws compile error: `~/NioDNS/Sources/DNSClient/DNSClient+Connect.swift:68:22: Value of type 'SocketAddress' has no member 'protocol'`
Update Package.resolved
See https://datatracker.ietf.org/doc/html/rfc6763#section-6.1 for TXT Records format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated at https://datatracker.ietf.org/doc/html/rfc6763#section-6.1 , TXT Record payload can be composed by multiple components (key/value pairs) that are preceded by a 8-bit integer indicating the length of the key/value pair.
An example of TXT Record is ( https://datatracker.ietf.org/doc/html/rfc6763#section-6.6 ):
This pull request fixes #9 . Also fixes IP Address to string conversion, since the IP Address returned was reversed and includes #8 .