Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support reusable postgres with custom DB name #785

Merged
merged 1 commit into from
Jan 21, 2023

Conversation

orlangure
Copy link
Owner

Fixes #774

@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2023

Codecov Report

Base: 86.11% // Head: 86.23% // Increases project coverage by +0.12% 🎉

Coverage data is based on head (38feb43) compared to base (0cb0065).
Patch coverage: 76.47% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #785      +/-   ##
==========================================
+ Coverage   86.11%   86.23%   +0.12%     
==========================================
  Files          49       49              
  Lines        2319     2325       +6     
==========================================
+ Hits         1997     2005       +8     
+ Misses        167      166       -1     
+ Partials      155      154       -1     
Impacted Files Coverage Δ
preset/postgres/preset.go 87.80% <76.47%> (+0.96%) ⬆️
docker.go 92.20% <0.00%> (+0.86%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@orlangure orlangure marked this pull request as ready for review January 21, 2023 14:12
@orlangure orlangure merged commit 8658ea5 into master Jan 21, 2023
@orlangure orlangure deleted the reusable-db-postgres branch January 21, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: postgres WithDatabase() causes failure on WithContainerReuse()
2 participants