Feature/81 depend on several fields

[frschi]

• added laravel default editorconfig
• added new functionality for multiple depend on fields at the same time
• removed unused dependKey from NovaBelongsToDepend.php

is backwards compatible with the old syntax

[cwilby]

This should support both string and array inputs for dependsOn.

if (this.fields.dependsOn instanceof Array) {
  // incoming changes
} else {
  Nova.$off(`nova-belongsto-depend-${this.field.dependsOn}`);
}

[cwilby]

Same here

[cwilby]

Added some recommendations to support backwards-compatibility

[cwilby]

Can be refactored to

updateDependsMap({ value, field: { modelClass, modelPrimaryKey } }) {
    const entry = this.field.dependsMap.find(e => e.key === modelClass);

    if (entry) {
        entry.value = value[modelPrimaryKey];
    } else {
        this.field.dependsMap.push({
            key: modelClass,
            value: value[modelPrimaryKey]
        });
    }
},

[cwilby]

Continuing the effort to make this a non breaking change, if $classNames has one entry, assign it to dependsOn, otherwise create and assign $classNames

[Sergej-Tihonov]

@cwilby thank you very much for your feedback and suggestions. I will apply them until the end of this week.

[Sergej-Tihonov]

@cwilby I have checked you suggestions in detailed. I have applyed them and taked a look at the end result.
I see that you want to keep all the old logic working as it was and apply only the new one on top.

Sorry, but I am agains that change.
My problem with that is, that this way we have to split the logic in two (string & array) in each place.
It's increase the complexity and we can avoid it.

The "string" path is unnecessary as we can handle this case very good with the "array" as well.

As you already highlighted in src/NovaBelongsToDepend.php
We get always an array here. So in the FormField.vue we can assume to have always an array, too.

There is one rare case, that I see where this can be not the case.
If someone does not use the "dependsOn(string ...$classNames)" method and access directly the field "$this->dependsOn"
It that case you run in some problems as you get not an array there.
We can throw an exception if(this.fields.dependsOn instanceof Array) is not an array, to make in obvious.

[cwilby]

@Sergej-Tihonov thanks for jumping in again 👍

I see your point, src/NovaBelongsToDepend.php uses params which wouldn't be a breaking change. No need to change that as I mentioned.

I don't think dependsOn is supposed to be directly reassigned, I agree with an exception if it's not an array. It would be nice however to normalize dependsOn to an array when it's referenced - is this possible?

$this->dependsOn = is_array($this->dependsOn) ? $this->dependsOn : [$this->dependsOn];

Also curious - why was this block removed?

-        if ($this->dependsOn) {
-            $this->dependKey = $resource->{$this->dependsOn}()->getForeignKeyName();
-        }

Thanks for pushing this forward!