-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dynMap 2.0: Major expansion of base functionality #3
base: master
Are you sure you want to change the base?
Conversation
*Total -- 7,939.95kb -> 7,606.72kb (4.2%) /dm/images/avernus-tiles/ash.png -- 26.22kb -> 20.11kb (23.31%) /dm/images/avernus-tiles/waste.png -- 25.26kb -> 20.13kb (20.31%) /dm/images/avernus-tiles/cracks.png -- 36.01kb -> 30.66kb (14.86%) /dm/images/lower.png -- 1,215.03kb -> 1,069.40kb (11.99%) /dm/images/avernus-tiles/fire.png -- 42.74kb -> 38.26kb (10.47%) /dm/images/avernus-tiles/mountains.png -- 59.62kb -> 54.17kb (9.13%) /dm/images/avernus-map.jpg -- 726.91kb -> 669.17kb (7.94%) /player/frontend/images/map.jpg -- 726.91kb -> 669.17kb (7.94%) /dm/images/avernus-tiles/bog.png -- 51.58kb -> 48.39kb (6.18%) /dm/images/avernus-tiles/hills.png -- 63.84kb -> 60.29kb (5.55%) /dm/images/avernus-tiles/volcano.png -- 70.69kb -> 67.02kb (5.18%) /dm/images/favicon.png -- 7.89kb -> 7.52kb (4.67%) /dm/images/avernus-tiles/brambles.png -- 119.11kb -> 116.27kb (2.38%) /dm/images/elturel-map.jpg -- 4,546.94kb -> 4,515.47kb (0.69%) /dm/images/upper.png -- 221.23kb -> 220.70kb (0.24%) Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>
[ImgBot] Optimize images
HOLY. COW. Your work is beyond impressive, great stuff! This was my first web dev project ever and looking back at the code I am a bit horrified by some of the choices I made... I haven't looked back at this repo for a good while now, because my group fell apart little over a year ago and we never got to finish the campaign, however I am extremely pleased to hear that someone else was able to use it for their own campaign. So, let me quickly go over your modifications and add some comments: Updated UIReally like the general vibe, the new location page style and the buttons. Great colour choices too. The only thing I am not too fond of here is the font. While it looks very hellyish, I personally have a bit of a hard time reading it. It might not be the best pick accessibility-wise. Elturel point crawlI personally didn't like the way the Remix had structured the Elturel section + my party had already begun exploring the city when I found out about the Remix, so I never got the chance to try the point crawl myself, but the way you structured it looks awesome and would probably work pretty well. Elturel random encountersNot much to say here, other than the previous comments about the font. Looks sick, but a bit hard to read. Good reference though, nice to always have under your eyes. Random generatorsVery good thinking on this one. If I might suggest a possible upgrade, it could be beneficial to add the possibility of persisting generated buildings and NPCs. Either through the browser localstorage (easier) or by downloading and uploading some JSON file. Either way, players might be interesting in visiting a random location more than once, or you as a DM might want to have some reference of all the NPCs that you have already introduced. Quest boardI didn't get the chance to try this one... The Final thoughtsI love the work you have done and will definitely be merging it (just give me a few days to properly test it and ensure everything works). I would even consider doing another round of "advertising" on the campaign subreddit and the remix's Discord, I think these new features are well worth it. What were you thinking about when you said you were interested in collaborating and "polishing the project"? Because I am going to be honest, since I am no longer using this for my own campaigns I am not too keen on spending too many hours adding additional features to it. At any rate, thank you so much for the work you have done and for having brought it to my attention, amazing job. |
Intro
Hi @ornato-t,
A few months back I came across your project when looking for resources to support my ongoing Descent Into Avernus campaign. Being a big fan of the Alexandrian remix, I was very happy to come across the good work you've done here. As I played around with the project locally, I started making small improvements to practice Vue, as I'm usually a React guy. This quickly snowballed into a small side-project, the result of which is this PR.
If you're interested, I'd love to collaborate on this and polish the project a bit more. Look through the changes I've made and let me know your thoughts.
New Stuff
Updated UI
Elturel Pointcrawl Map with Key'd Nodes
Random Encounters
Random Building & NPC Generators
Quest Board System