Port ui/editor to snabbdom and TypeScript #5655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome. Is that ready? |
niklasf
commented
Nov 19, 2019
| @@ -21,7 +21,7 @@ object editor { | |||
| moreJs = frag( | |||
| jsAt(s"compiled/lichess.editor${isProd ?? (".min")}.js"), | |||
| embedJsUnsafe(s"""var data=${safeJsonValue(bits.jsData(sit, fen, animationDuration))};data.positions=$positionsJson; | |||
| LichessEditor(document.getElementById('board-editor'), data);""") | |||
| LichessEditor.default(document.querySelector('#board-editor > .board-editor'), data);""") | |||
There was a problem hiding this comment.
Looks like snabbdom replaces the element instead of replacing its content. I wonder if there is a more elegant way.
There was a problem hiding this comment.
I think in the other modules I just recreate the main#board-editor root with snabbdom.
There was a problem hiding this comment.
It's a bit awkward, because the editor can also be embedded in the study chapter dialog.
|
I think so, yes. Edit: In it's current form, requires full deploy, because of the issue above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.