Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: unify jest configs between insurance and education repositories [no issue] #1059

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

sylvaingrasland-ornikar
Copy link
Contributor

Context

We want to unify our jest configurations.

Solution

Extract configuration parts from insurance and education repositories that appear to be the same.

Copy link

reviewflow bot commented Jan 22, 2024

Progress

☑️ Step 1: ✏️ Write code
☑️ Step 2: 💚 Checks
☑️ Step 3: 👌 Code Review
☑️ Step 4: 🚦 Merge Pull Request

Options:

  • 🔜 automerge: Automatically merge when this PR is ready and has no failed statuses. When the repository requires branches to be up to date before merging, it merges default branch, with a queue per repo to prevent multiple merges when several PRs are ready. A fail job prevents the merge.
  • 🚦 skip-ci: Add [skip ci] on merge commit when merge is done with autoMerge.

Actions:

  • 🐛 Force updating reviewflow checks for this PR. Use this to try to fix reviewflow checks that are still missing/pending, which might happen if webhook failed or something bad happened when reviewflow tried to send the status check to github.
  • 🔄 update branch: Merge base branch in this PR's branch. Only works if merging is possible without conflicts.

@sylvaingrasland-ornikar sylvaingrasland-ornikar changed the title feat: unify jest configs between insurance and education repositories feat: unify jest configs between insurance and education repositories [no issue] Jan 22, 2024
Copy link
Contributor

@christophehurpeau christophehurpeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

petits commentaires 🙈

@ornikar/jest-config/jest-preset.js Show resolved Hide resolved
@PSniezak
Copy link
Contributor

Yo ! J'ai pu faire des tests côté learner-apps, ça m'a l'air de tourner comme il faut et ça m'a permis de faire un bon coup de clean en même temps : https://github.com/ornikar/learner-apps/pull/6340.

On pourra arbitrer demain pour le reste, merci Sylvain !

@PSniezak PSniezak marked this pull request as ready for review February 14, 2024 09:08
@PSniezak PSniezak requested a review from a team as a code owner February 14, 2024 09:08
@sylvaingrasland-ornikar sylvaingrasland-ornikar merged commit 620d711 into main Feb 15, 2024
10 checks passed
@sylvaingrasland-ornikar sylvaingrasland-ornikar deleted the feat/common_jest_config branch February 15, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants