Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize processing attributes, by using a new AttributeBase.Equals()… #3299

Merged
merged 1 commit into from Jul 28, 2022

Conversation

pnorbert
Copy link
Contributor

… function instead of building a small string map. Also speed up BP5Deserializer.BreakDownVarName, and BreakDownArrayName by using strtol() calls instead of sscanf.

… function instead of building a small string map. Also speed up BP5Deserializer.BreakDownVarName, and BreakDownArrayName by using strtol() calls instead of sscanf.
@pnorbert pnorbert requested a review from eisenhauer July 27, 2022 19:16
Copy link
Member

@eisenhauer eisenhauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good...

@pnorbert pnorbert merged commit 9d66e65 into ornladios:master Jul 28, 2022
@pnorbert pnorbert deleted the optimize_attribute_processing branch July 28, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants