Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essentially this PR:
What is not done here is to change anything other than the C++ bindings. When the Struct bindings are finalized in C++, C bindings at least should follow. We also need to see if we can support Fortran derived types and numpy structured arrays.
Having DefineStruct in the ADIOS was likely motivated by the idea that a struct definition is like a
typedef
, something that is hardcoded into an application, known to be fixed at compile-time, maybe has a simple name that's unique across the entire source code, etc. Assumptions like these easily accommodate simple producer/consumer situations where all parties have full a priori knowledge of the data being exchanged, but they are insufficient to support ADIOS' goals of discovery and introspection. This is a step towards those goals for the struct interface.