Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docs/README.md for using conda env #3427

Merged
merged 1 commit into from Mar 14, 2023

Conversation

caitlinross
Copy link
Collaborator

@caitlinross caitlinross commented Jan 5, 2023

docs/requirements.txt no longer used as of #1586.
docs/requirements.txt actually removed in #3134.

This PR adds docs/requirements.txt back to the repo, so you can build locally without needing conda and updates docs/README.md to provide correct instructions for building docs locally with conda or pip.

anagainaru
anagainaru previously approved these changes Feb 2, 2023
@eisenhauer
Copy link
Member

@vicentebolea Want this in 2.9?

@vicentebolea
Copy link
Collaborator

@eisenhauer yes

@vicentebolea vicentebolea added this to the v2.9.0 milestone Feb 28, 2023
@caitlinross caitlinross changed the base branch from master to release_29 March 10, 2023 17:24
@caitlinross
Copy link
Collaborator Author

@vicentebolea It won't let me merge because of the contract tests? It says they're expected but still waiting on them 4 days later.

@vicentebolea vicentebolea merged commit 93de6b2 into ornladios:release_29 Mar 14, 2023
@vicentebolea
Copy link
Collaborator

I just merged it, without changes in the source files those builds do not start.

vicentebolea added a commit that referenced this pull request Mar 14, 2023
update docs/README.md for using conda env
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants