Fix build error on Summit for PGI with CUDA backend #3481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshitij-v-mehta
approved these changes
Feb 10, 2023
eisenhauer
approved these changes
Feb 10, 2023
Co-authored-by: Greg Eisenhauer <eisen@cc.gatech.edu>
|
Should have gone to release_29. @vicentebolea |
It can still make it to the v2.9.0 final release :) |
|
@pnorbert @vicentebolea Sorry I didn't see this discussion and assume the tag was a mistake :) Once the Kokkos backend is done this PR will be completely overwritten that is why I wasn't sure we need the tag. But I'll keep it just in case the Kokkos backend won't make it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3257
This will be overwritten by the new GPU backend logic introduced in v2.9.0