Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build scripts for ADIOS2 with CUDA and Kokkos backend #3579

Merged
merged 3 commits into from
Apr 8, 2023

Conversation

anagainaru
Copy link
Contributor

For Summit, Perlmutter and Crusher

@anagainaru
Copy link
Contributor Author

I am not sure we need 5 scripts, a lot of the things are the same but I didn't know where to document how to build Kokkos and what modules to use for each system.

Copy link
Collaborator

@vicentebolea vicentebolea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anagainaru they look great! I am in favor of having those as a help to deploy in those systems.

We normally pass the shellcheck script on shell scripts. Can you pass it and fix the potential warnings?

scripts/build_scripts/build-adios2-cuda-perlmutter.sh Outdated Show resolved Hide resolved
@vicentebolea
Copy link
Collaborator

I am not sure we need 5 scripts, a lot of the things are the same but I didn't know where to document how to build Kokkos and what modules to use for each system.

Maybe it is just ok for now, if we use those scripts more we can improve them iteratively

@anagainaru
Copy link
Contributor Author

I did not know about shellcheck, that's so cool. Will fix all the warnings and the build names

@anagainaru
Copy link
Contributor Author

I fixed the warnings and the naming, I testing the new versions on Summit just to make sure I did not introduce some issues and it seems good.

pnorbert
pnorbert previously approved these changes Apr 7, 2023
@vicentebolea
Copy link
Collaborator

@anagainaru can you do a amend and repush, it seems that the CI did not start. Lets try our new shellcheck test :)

@anagainaru
Copy link
Contributor Author

@vicentebolea I tried shellcheck online and I did not get this warnings.
I am not sure I understand what I am supposed to do for most of them. What is this one saying?

In scripts/build_scripts/build-adios2-cuda-perlmutter.sh line 21:
    -D CMAKE_INSTALL_PREFIX="${INSTALL_DIR}"
       ^-------------------^ SC2191: The = here is literal. To assign by index, use ( [index]=value ) with no spaces. To keep as literal, quote it.

@vicentebolea
Copy link
Collaborator

vicentebolea commented Apr 8, 2023

I am not sure I understand what I am supposed to do for most of them. What is this one saying?

I think that shellcheck is all confused about -D KEY=VALUE type of argument, you can either do like "-DKEY=VALUE" or disable that specify check in that file. by adding # shellcheck disable=SC2191

@anagainaru anagainaru merged commit 69be5d1 into ornladios:master Apr 8, 2023
@anagainaru anagainaru deleted the build-scripts-gpu-aware branch November 18, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants