Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add libcurl4 to all ubuntu images #3734

Merged

Conversation

scottwittenburg
Copy link
Collaborator

@scottwittenburg scottwittenburg commented Aug 2, 2023

Fixes #3694

@vicentebolea
Copy link
Collaborator

The BP5 test error seems to be a race condition: https://open.cdash.org/test/1161780125. This is out of the scope of this PRs.

@eisenhauer

Copy link
Collaborator

@vicentebolea vicentebolea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error in the win build is unrelated to this. Note that the OLCF builds have been not working for a couple of hours (outage). Now they are again working but it will take a while to get through the backlog of commits to test.

@scottwittenburg
Copy link
Collaborator Author

Ok, I have built and pushed the images resulting from this change. Feel free to merge if you think it's ok. I'd do it, but I don't have permission.

@vicentebolea
Copy link
Collaborator

You should be able to merge now, I removed the requirement for the branch to be uptodate

@scottwittenburg scottwittenburg merged commit 2e70e01 into ornladios:master Aug 2, 2023
28 of 29 checks passed
@scottwittenburg scottwittenburg deleted the ci-ubuntu-add-libcurl4 branch August 2, 2023 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Libcurl in some of our Github builds
2 participants