Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Create static minimal build #3760

Merged

Conversation

vicentebolea
Copy link
Collaborator

@vicentebolea vicentebolea commented Aug 15, 2023

This is needed since the current static builds fails to build the unit tests since they take more disk space than what GH give us.

It is also worth to have a minimal build to test that setup, this is valuable for users that want to embedded adios somewhere.

  • It also disables ADIOS2_USE_BP5 options since we do not support not having BP5 enabled anymore.
  • It also fixes the dependency with FFS so that we properly export its cmake targets.
  • It also removes a warning in cdash about MGARD not enabled when using a static build.

Fixes: #3751
Fixes: #3148

@vicentebolea vicentebolea force-pushed the create-minimal-static-build branch 12 times, most recently from 58ca66d to c65e3bd Compare August 16, 2023 01:23
@vicentebolea
Copy link
Collaborator Author

We are hitting an error here https://open.cdash.org/test/1176036167: The test expect to always use BP5. Does it make sense to have a build BP5=OFF?

@pnorbert

@vicentebolea vicentebolea force-pushed the create-minimal-static-build branch 4 times, most recently from bf2f330 to 98625aa Compare August 16, 2023 16:34
@vicentebolea vicentebolea force-pushed the create-minimal-static-build branch 3 times, most recently from 1a95b26 to fdf4197 Compare August 22, 2023 21:24
@vicentebolea vicentebolea force-pushed the create-minimal-static-build branch 3 times, most recently from eb1d4ae to df82671 Compare August 23, 2023 01:35
@vicentebolea
Copy link
Collaborator Author

@eisenhauer can you review this? Thanks :)

Copy link
Member

@eisenhauer eisenhauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as far as I can see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable unit tests in ADIOS2 static CI build Static build, BP5 on SST off fails
2 participants