Enable shell check scripts for existing scripts #3940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spyridon97
force-pushed
the
enable-shell-check-contract-scripts
branch
2 times, most recently
from
46a603c
to
a3b5597
Compare
|
@spyridon97 thanks for the this change. We have to be very careful with these changes since we do not test all those files in CI, that it is why we have this "exclude" list. Everything which is not cover in CI should not be modified (Unless you run those scripts and verify that they work). Please remove changes for |
spyridon97
force-pushed
the
enable-shell-check-contract-scripts
branch
5 times, most recently
from
ee99661
to
3e8545b
Compare
|
@vicentebolea i see a weird ascent kokkos failure, shall i ignore this? If yes, can you approve? |
vicentebolea
requested changes
Dec 1, 2023
Yeah, the ascent build is flaky, you can ignore it |
spyridon97
force-pushed
the
enable-shell-check-contract-scripts
branch
from
3e8545b
to
7d470fd
Compare
|
@vicentebolea can you approve now? |
vicentebolea
approved these changes
Dec 4, 2023
spyridon97
force-pushed
the
enable-shell-check-contract-scripts
branch
from
7d470fd
to
ea4a249
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable shell check scripts for existing scripts