-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport master commits #4029
Merged
vicentebolea
merged 27 commits into
ornladios:release_210
from
vicentebolea:backport-master
Feb 12, 2024
Merged
Backport master commits #4029
vicentebolea
merged 27 commits into
ornladios:release_210
from
vicentebolea:backport-master
Feb 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t to adjust the variable dimensions
…ith different layout combinations
* Fix ChunkV maintaining CurOffset when downsizing current chunk in Allocate() and creating the next chunk. * Rename test. fix windows compile errors. * clang format
… of an ASAN error blocking local testing. (ornladios#4013)
- Allow Stream/FileReader constructor overloading and Stream.read()/write() overloading using @singledispatchmethod. - Return status from engine when using Stream.begin_step(). - Update examples with the changes to the API - Update python examples (hello_world, bpWriter, gray-scott, dataMan) - Change stream iterator to use engine BeginStep return status - Create python DataMan/SST writers and readers for both high-level and bindings APIs, and make them work with the C++ example versions. - Require python 3.8 as minimum, when @singledispatchmethod was introduced - Update some documentation, remove some io functions from stream that would be too late to call - Rename variable writer to io in testing consistently
…python39 but actual images is not built.
Code extracted from: https://github.com/GTkorvo/ffs.git at commit e8989c262d380ab305e99bd4056073729b7d304d (master). Upstream Shortlog ----------------- Co-authored-by: ffs Upstream <robot@adios2>
…os#3997) * Add test for local operator, tweak posix transport to fail on EOF when desired, add a unit test * Disable posix test on Windows
Added exception for writing operation.
eisenhauer
approved these changes
Feb 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't done line-by-line, but what I'm familiar with here looks good.
@pnorbert Check out the spurious failure. https://open.cdash.org/test/1415367968. Any idea why we'd be non-deterministically be reading past the end of file here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It backports the following PRs:
87fe33e (upstream/master, origin/master, origin/HEAD, master) Merge pull request #4024 from dmitry-ganyushin/campaign-bug
b074760 Merge pull request #4014 from pnorbert/update-python-examples
8ad7d2d Merge 3769 to master (#4011)
c7bd581 Merge pull request #3976 from anagainaru/gpu-layout-simpler
675fedb Merge pull request #4000 from dmitry-ganyushin/campaign-json-to-sqlite3
08e7f30 Merge pull request #4001 from vicentebolea/update-readthedocs
252c3fa Merge pull request #4003 from vicentebolea/update-codeowners
1b5e36b Merge pull request #3989 from eisenhauer/BP5LocalOp
9f9248a Merge pull request #3979 from vicentebolea/adios2-version-fix