Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fix for the issue 4131. Included only for linux. #4137

Conversation

dmitry-ganyushin
Copy link
Contributor

FileHTTP.cpp is include in build only for linux until further fix.

@eisenhauer
Copy link
Member

Generally I think we’d rather move in the direction of making the code portable rather than excluding certain functionality from certain platforms. That’s a slippery slope with an unpleasant end.

@dmitry-ganyushin dmitry-ganyushin self-assigned this Apr 9, 2024
@dmitry-ganyushin
Copy link
Contributor Author

That is only a quick fix to make build for FreeBSD (untested on FreeBSD)

@eisenhauer
Copy link
Member

Dmitry, I'm going to close this because PR #4138 takes care of this problem by making the file in question compile on FreeBSD.

@eisenhauer eisenhauer closed this Apr 15, 2024
@dmitry-ganyushin
Copy link
Contributor Author

Auto tests are missing. How to test functionality?

@eisenhauer
Copy link
Member

Auto tests are missing. How to test functionality?
On step at a time. PR #4138 just adds a #include so the build isn't broken on FreeBSD. I'll do windows too because that's pretty quick and easy. Adding tests and other mods will probably wait until we have a performant use case. For now, just trying to keep this code around in the anticipation that we might have such a case in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants