Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix python char #4144

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Fix python char #4144

merged 1 commit into from
Apr 18, 2024

Conversation

pnorbert
Copy link
Contributor

  • based on char signess in installed adios library, use numpy.int8 or numpy.uint8 to read char arrays from BP files
  • move char as last type in adios type macros, so that unsigned char always becomes uint8_t and signed char becomes int8_t in output (char arrays still become char in output)
  • add C++ test to write and read char/signed char/unsigned char arrays

fixes #4140

@pnorbert
- based on char signess in installed adios library, use numpy.int8 or…
c6ff249 
… numpy.uint8 to read char arrays from BP files

- move char as last type in adios type macros, so that unsigned char always becomes uint8_t and signed char becomes int8_t in output (char arrays still become  char in output)
- add C++ test to write and read char/signed char/unsigned char arrays
@pnorbert pnorbert added this to the v2.10.1 milestone Apr 17, 2024
@pnorbert pnorbert merged commit 1f2ca67 into ornladios:release_210 Apr 18, 2024
45 of 72 checks passed
@pnorbert pnorbert deleted the fix-python-char branch April 18, 2024 13:04
@vicentebolea vicentebolea mentioned this pull request May 28, 2024
Merged
vicentebolea added a commit to vicentebolea/ADIOS2 that referenced this pull request May 28, 2024
@vicentebolea
fix: make changes from ornladios#4144 abi compat
df6b2bc
vicentebolea added a commit to vicentebolea/ADIOS2 that referenced this pull request May 28, 2024
@vicentebolea
fix: make changes from ornladios#4144 abi compat
f839acd
vicentebolea added a commit that referenced this pull request May 29, 2024
@vicentebolea
Merge branch 'release_210'
040c3f0 
* release_210:
  Bump version to v2.10.1
  Kill outdated reference to bindings.Mode.ReadFlattenSteps (#4185)
  fix: make changes from #4160 abi compat
  fix: make changes from #4144 abi compat
  Remove special ReadFlattenSteps Mode, switch to control by writer-sid… (#4160)
  EVPath 2024-05-27 (45471c87) (#4181)
  Add API call to reset memory selection (#4169)
  Typo in the build command inside the documentation (#4166)
  Merge pull request #4161 from anagainaru/derived-performance
  Minor docs tweaks (#4153)
  ReadModeFlatten (#4147)
  Merge pull request #4142 from vicentebolea/fix-pugixml-dep
  Fixes for FreeBSD, including upstream (#4138)
  Deactivate campaign recording by default. Use .adios-campaign/ as directory name.
  test CI fix (#4177)
  - based on char signess in installed adios library, use numpy.int8 or numpy.uint8 to read char arrays from BP files - move char as last type in adios type macros, so that unsigned char always becomes uint8_t and signed char becomes int8_t in output (char arrays still become  char in output) - add C++ test to write and read char/signed char/unsigned char arrays
  dill 2024-04-04 (55420dee) (#4136)
  pugixml: correct target name
@BrewTestBot BrewTestBot mentioned this pull request May 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eisenhauer eisenhauer eisenhauer approved these changes

@vicentebolea vicentebolea Awaiting requested review from vicentebolea vicentebolea is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.10.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pnorbert @eisenhauer