Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is your maxpooling layer wrong? #43

Open
eliottbrion opened this issue Jan 4, 2018 · 2 comments
Open

Is your maxpooling layer wrong? #43

eliottbrion opened this issue Jan 4, 2018 · 2 comments

Comments

@eliottbrion
Copy link

Hello,

I checked both shapes of conv1 and pool1 and they don't seem to be coherent:
K.int_shape(conv1)
(None, 32, 48, 48)
K.int_shape(pool1)
(None, 16, 24, 48)
It looks like you're doing the maxpooling operation on the feature map.

In retina-unet/src/retinaNN_training.py, don't you think that you should replace the 37th line
pool1 = MaxPooling2D((2, 2))(conv1)
by
pool1 = MaxPooling2D((2, 2),data_format='channels_first')(conv1)?

Eliott

@eliottbrion eliottbrion changed the title Is you maxpooling layer wrong? Is your maxpooling layer wrong? Jan 4, 2018
@itachi1232gg
Copy link

@eliottbrion I think you are right, I found this error as well. What interesting is, it does not affect the results a lot.

@liuzhibo-delta
Copy link

I agree with you , the UpSampling Layer as well as the Maxpooling Layer are Wrong . Because of the parameter data_format='channels_first' is missing . You can correct it .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants