Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

staged extraction w/ existing node_modules support #177

Closed
zkat opened this issue Feb 25, 2023 · 0 comments · Fixed by #200
Closed

staged extraction w/ existing node_modules support #177

zkat opened this issue Feb 25, 2023 · 0 comments · Fixed by #200
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@zkat
Copy link
Member

zkat commented Feb 25, 2023

Right now, extraction/restore assumed there's no node_modules at all, and always extracts everything directly to its destination. We should instead consider extracting to a temporary directory and "atomically" moving things around so we can roll back in case of failure.
@zkat zkat added enhancement New feature or request help wanted Extra attention is needed labels Feb 25, 2023
@zkat zkat mentioned this issue Mar 12, 2023
Merged
@zkat zkat closed this as completed in #200 Mar 12, 2023
zkat added a commit that referenced this issue Mar 12, 2023
@zkat
feat(prune): check for an prune extraneous packages, and skip extract…
544a2c5 
…ing valid ones (#200)

Fixes: #149
Fixes: #177
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
Orogene 1.0 Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(prune): check for an prune extraneous packages, and skip extracting valid ones orogene/orogene
1 participant
@zkat