Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolver generates invalid/incompatible trees on update #241

Closed
zkat opened this issue Apr 13, 2023 · 0 comments · Fixed by #247
Closed

resolver generates invalid/incompatible trees on update #241

zkat opened this issue Apr 13, 2023 · 0 comments · Fixed by #247
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@zkat
Copy link
Member

zkat commented Apr 13, 2023

When dependencies are updated in package.json to a version incompatible with previously-installed dependents, the dependents don't re-evaluate their dependencies, and the tree ends up in an invalid state.

The repro is pretty easy:

  1. npx create-react-app react-app && cd react-app && rm -rf node_modules package-lock.json
  2. cargo run -- add lodash@3

Using cargo run here in debug mode is important, because it's the debug_assertions for validating trees that caught this.

@zkat zkat added bug Something isn't working help wanted Extra attention is needed labels Apr 13, 2023
@zkat zkat self-assigned this Apr 17, 2023
@zkat zkat linked a pull request Apr 17, 2023 that will close this issue
@zkat zkat closed this as completed in #247 Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant