Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually publish to brew #297

Closed
zkat opened this issue Sep 29, 2023 · 8 comments
Closed

Actually publish to brew #297

zkat opened this issue Sep 29, 2023 · 8 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@zkat
Copy link
Member

zkat commented Sep 29, 2023

we're generating brew-related artifacts now with the latest version of cargo-dist, but we're not actually uploading it to brew. Should probably figure out how to do that. If anyone wants to pick this up, I'd appreciate the help, especially if we can automate it :)

@zkat zkat added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Sep 29, 2023
@jasikpark
Copy link

afaik, all you need is a git repo and a build command for homebrew, ex: https://github.com/Homebrew/homebrew-core/blob/master/Formula/n/nebula.rb

a formula is an instance of the Formulae class in ruby, which has a lot of default behavior, so it should be simple.

there's also automatic bots that will use https://docs.brew.sh/Brew-Livecheck to check for new versions, so it should be low-maintenance as long as the build api doesn't change

@jasikpark
Copy link

@jasikpark
Copy link

jasikpark commented Sep 29, 2023

the guide for what brew lints are wanted for a new formula: https://docs.brew.sh/How-To-Open-a-Homebrew-Pull-Request

@zkat
Copy link
Member Author

zkat commented Sep 29, 2023

fwiw, we already generate a formula: https://github.com/orogene/orogene/releases/tag/v0.3.31

so I guess this is just figuring out how to best create those PRs against brew and ideally automate the process.

@jasikpark
Copy link

hmm ig the advantage of automatically generating PRs from here is that they're closer to synchronous w/ release rather than relying on the homebrew git bot to generate a PR?

@mckern
Copy link

mckern commented Sep 29, 2023

Following up on ^^: there's basically two options/paths: you stick your homebrew formula that you're generating into a tap or you go through their new formula process and their bot will then monitor this repo and update their accepted formula (and all the binary artifacts that they will generate) automatically. But the formula you're generating will probably not be accepted by them as-is and if you use tags & releases, then you generally don't have to notify them that your repo has been updated unless you want ASAP updates on the formula they carry.

@jasikpark
Copy link

Put up Homebrew/homebrew-core#147422 as a draft PR of option #2 - it definitely needs some work though :p

@zkat
Copy link
Member Author

zkat commented Sep 30, 2023

Linking cargo-dist's docs on doing this here: https://opensource.axo.dev/cargo-dist/book/installers/homebrew.html

@zkat zkat closed this as completed in 5c0c77a Sep 30, 2023
zkat added a commit that referenced this issue Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Status: Done
Development

No branches or pull requests

3 participants