Add resolve & link progress bars #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkat
reviewed
Feb 24, 2023
| let pb_style = ProgressStyle::default_bar() | ||
| .template("💾 {bar:40} [{pos}/{len}] {wide_msg}") | ||
| .unwrap(); | ||
| let pb = ProgressBar::new(self.graph.inner.edge_count() as u64).with_style(pb_style); |
There was a problem hiding this comment.
2 things:
- Anywhere that we use
indicatifshould only do things on non-wasm32, and should be conditionalized appropriately. - There should be a configuration, through
NodeMaintainerOptions, that configures whether or not progress bars should be shown. This should default to false (because the default assumption is for node-maintainer to be used as a plain library without unwanted output)
There was a problem hiding this comment.
Hopefully achieved what you meant here:
ed6711d
If it's way too ugly please let me know!
zkat
reviewed
Feb 24, 2023
zkat
force-pushed
the
main
branch
7 times, most recently
from
50afeaf
to
36affb0
Compare
|
Thanks again for all this! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a progress bar to resolve & link steps (so
oro resolvewill only show one, andoro restorewill show both).For both - the progress bar's length is the expected edge count on the dependency graph.
For linking - we increase the progress for each dependency we link, and then call
finishto round it up to the actual edge count, so while we don't link each edge necessarily, the progress bar will count those in, wasn't sure that's desired or not.Screen.Recording.2023-02-24.at.22.38.33.mov
This is very basic and naive, feedback is very welcome!