Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change BUFFER_SIZE type to usize #49

Closed
orottier opened this issue Nov 10, 2021 · 1 comment
Closed

Change BUFFER_SIZE type to usize #49

orottier opened this issue Nov 10, 2021 · 1 comment
Labels
good first issue Good for newcomers

Comments

@orottier
Copy link
Owner

I don't think u32 is a great choice, we're almost always casting it to usize anyway

See related discussion #47 (comment)_
@orottier orottier added the good first issue Good for newcomers label Nov 10, 2021
b-ma added a commit to b-ma/web-audio-api-rs that referenced this issue Nov 15, 2021
@b-ma
changed BUFFER_SIZE to usize (cf. orottier#49)
579078f
b-ma added a commit to b-ma/web-audio-api-rs that referenced this issue Nov 15, 2021
@b-ma
changed BUFFER_SIZE to usize (cf. orottier#49)
0ca046c
orottier added a commit that referenced this issue Nov 17, 2021
@orottier
Merge pull request #52 from b-ma/feature/buffer-size
a32309a 
changed BUFFER_SIZE to usize (cf. #49)
@orottier
Copy link
Owner Author

Fixed in #52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@orottier