Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set BaseAudioContext::state by render thread to signal device readiness #419

Merged
merged 9 commits into from
Jan 4, 2024
Merged

Set BaseAudioContext::state by render thread to signal device readiness #419

merged 9 commits into from
Jan 4, 2024

Commits on Jan 2, 2024

  1. BaseAudioContext::state set by render thread to signal device readiness 

    Fixes #410

Except for suspending/resuming, I don't have a solution for that yet.

In summary:
- A context is instantiated in Suspended state
- Online context will change to Running at the first render quantum
- Online context will change to Closed when the render thread is dropped
  after a `close` call
- Online context suspend/resume state is still managed by the control
  thread - TODO
- Offline context will change to Running after startRendering
    @orottier
    orottier committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    217ed1a View commit details
    Browse the repository at this point in the history

  2. OfflineAudioContext should set state to suspended when suspending 

    Fixes #416
    @orottier
    orottier committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    caa6c51 View commit details
    Browse the repository at this point in the history

  3. Validate panics in #101 are fixed (sending ctrl msgs to closed context) 

    Fixes #101
    @orottier
    orottier committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    fcbb67a View commit details
    Browse the repository at this point in the history

  4. Silence clippy

    @orottier
    orottier committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    e54c5b7 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2024

  1. Ensure AudioContext suspend/resume_sync block control thread until co… 

    …mpleted
    @orottier
    orottier committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    50e115f View commit details
    Browse the repository at this point in the history

  2. Ensure AudioContext close_sync blocks control thread until completed

    @orottier
    orottier committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    ad24275 View commit details
    Browse the repository at this point in the history

  3. Add async versions of AudioContext suspend/resume/close

    @orottier
    orottier committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    e9330cd View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2024

  1. Fix confusing naming of suspend/resume/close control messages

    @orottier
    orottier committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    480f6d1 View commit details
    Browse the repository at this point in the history

  2. Make test more robust by sleeping to prevent event thread racing

    @orottier
    orottier committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    0644fe2 View commit details
    Browse the repository at this point in the history